spago icon indicating copy to clipboard operation
spago copied to clipboard

aeson 2.0 compatibility

Open maralorn opened this issue 2 years ago • 2 comments

As of a few days ago, there is a new bower-json version which supports aeson 2.0.

Now to support aeson 2.0 there are only the build errors in spago itself left. I get the following build error, when trying to build with aeson 2.0, but it might be masking more:

src/Spago/Bower.hs:112:33: error:
    • Couldn't match type: Data.Aeson.KeyMap.KeyMap Value
                     with: HashMap k0 a0
      Expected: HashMap k0 a0
        Actual: Object
    • In the second argument of ‘HashMap.member’, namely ‘info’
      In the expression: HashMap.member "version" info
      In a stmt of a 'do' block:
        if HashMap.member "version" info then
            pure $ Bower.VersionRange $ "^" <> version
        else
            pure $ Bower.VersionRange $ repo <> "#" <> version
    |
112 |     if HashMap.member "version" info
    |                                 ^^^^

maralorn avatar May 21 '22 10:05 maralorn

@maralorn I'd happily merge a patch with the updates if you'd like to have a go at this! Otherwise I'll take care of it, but it might take a while before I get to this.

f-f avatar May 21 '22 12:05 f-f

I am not in hurry and don’t use spago myself. It just came up during NixOS maintenance.

maralorn avatar May 21 '22 14:05 maralorn

Fixed in #901

f-f avatar May 04 '23 16:05 f-f