purescript-lists

purescript-lists copied to clipboard

**Description of the change** Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include...

evaogbe

Data.List.NonEmpty.intersect and Data.List.NonEmpty.intersectBy throw when intersection empty

2

I think they should be changed to match the implementation of the corresponding functions in `NonEmptyArray`, i.e. return a `List` instead of a `NonEmptyList`. Alternatively, I saw the discussion in...

evaogbe-vermeer

Add Data.List.NonEmpty.deleteAt

4

https://pursuit.purescript.org/packages/purescript-lists/5.4.1/docs/Data.List.NonEmpty `Data.List.NonEmpty.deleteAt` function doesn't exist, but * [`Data.List.deleteAt`](https://pursuit.purescript.org/packages/purescript-lists/5.4.1/docs/Data.List#v:deleteAt) * [`Data.Array.NonEmpty.deleteAt`](https://pursuit.purescript.org/packages/purescript-arrays/5.3.1/docs/Data.Array.NonEmpty#v:deleteAt) do exist. Seems like we should add `Data.List.NonEmpty.deleteAt` ?

jamesdbrock

**Description of the change** - Export `tails`; make it stack safe - Implement `inits` Note: the `inits` test currently fails with a "JavaScript heap out of memory" error because we're...

JordanMartinez

Infix operator (:||) for NonEmptyList cons'

4

**Description of the change** Motivation for this change is to give users a more ergonomic alternative to: https://github.com/purescript/purescript-lists/blob/6d8e30eeb9714bc422b6fb75ad1b0f43bef59703/src/Data/List.purs#L619-L620 We can currently do a little better with NonEmpty's `:|` operator: ```purs...

milesfrain

Document (or fix) stack safety issues

5

Some example of existing stack-unsafe functions: - `sort` - reported in #192 - `nubEq`, can be fixed for strict lists by applying same strategy used for struct `nub` in #179...

milesfrain

sort and sortBy are not stack safe

4

```purs sort $ range 1 1000000 ``` ``` /home/miles/projects/purescript/lists/output/Data.List/index.js:287 return as(new Data_List_Types.Cons(a, ys)); ^ RangeError: Maximum call stack size exceeded at $tco_var_as (/home/miles/projects/purescript/lists/output/Data.List/index.js:287:39) ``` Should we swap out this current...

milesfrain

Generalize `filterM` (etc.?) to `Applicative`

3

Today I noticed that [PureScript `filterM` is constrained to `Monad`](https://pursuit.purescript.org/packages/purescript-lists/5.4.0/docs/Data.List#v:filterM), whereas [Haskell `filterM` is constrained to `Applicative`](https://hackage.haskell.org/package/base-4.12.0.0/docs/Control-Monad.html#v:filterM). After looking at the source code for each and asking on FP Slack,...

glebec

Patch API differences

3

See https://github.com/purescript/purescript-lists/issues/183#issuecomment-825460643 for a proposed API --- It looks like there are a few missing `functions` and `instances` across the different list modules in this library. To tackle this more...

milesfrain

List.Lazy insertAt, modifyAt, updateAt, deleteAt, alterAt members behave differently to List and Array

3

They always return a `List a` even when the index is out of range, whereas the other modules return a `Maybe (List a)` or `Array (List a)` for when the...

garyb