purescript-arrays icon indicating copy to clipboard operation
purescript-arrays copied to clipboard

Use Natural Transformations wherever possible

Open milesfrain opened this issue 4 years ago • 3 comments

This change makes the type signatures of NonEmptyArray functions more consistent with the other container types.

Here's an example of the previous inconsistencies: https://pursuit.purescript.org/search?q=toUnfoldable

milesfrain avatar Jan 06 '21 19:01 milesfrain

FWIW this is something that we explicitly decided against previously. There will be discussion on a closed issue or PR in this repo or potentially one of the other core library repos.

hdgarrood avatar Jan 06 '21 19:01 hdgarrood

I wasn't aware that the lists library uses the ~> type synonym. I agree that these should be consistent, but I think we should change the lists library to remove uses of ~> rather than adding them here.

hdgarrood avatar Jan 27 '21 11:01 hdgarrood

I agree that these should be consistent, but I think we should change the lists library to remove uses of ~> rather than adding them here.

I agree with this, too. It avoids the issue of confusion that can arise if someone doesn't know what ~> is.

JordanMartinez avatar Jan 27 '21 20:01 JordanMartinez