psc-package icon indicating copy to clipboard operation
psc-package copied to clipboard
verified publisher icon purescript

Deprecated GitHub API usage when uploading releases

Open hdgarrood opened this issue 6 years ago • 2 comments

I received this email yesterday from GitHub: it sounds like the script for uploading release binaries is using a deprecated API. Hopefully updating the github-release version should be sufficient to fix this? I’m not sure.

Hi @hdgarrood,

On February 8th, 2020 at 00:21 (UTC) your personal access token (AppVeyor psc-package release uploads) using Go-http-client/1.1 was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/81163698/releases

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

hdgarrood avatar Feb 08 '20 12:02 hdgarrood

Looks like the github-release tool and the fork won't work https://github.com/purescript/psc-package/blob/01263f559a87a36ccacb5fef9c2b4b88282730f3/appveyor.yml#L29

We use the newest version already https://github.com/aktau/github-release/releases

So probably we need to replace this altogether

justinwoo avatar Feb 08 '20 12:02 justinwoo

Ah right yeah, that’s a shame. FWIW Travis CI offers windows builds now and that’s what we use for the compiler, they seem to work well enough.

hdgarrood avatar Feb 08 '20 12:02 hdgarrood