vimspector icon indicating copy to clipboard operation
vimspector copied to clipboard

Don't display frame ID on stack trace

Open samisalreadytaken opened this issue 5 months ago • 6 comments

Frame ID is an opaque data that does not concern the end user. Different servers assign them differently. For example this python server has IDs 3,2,12,24; this c server has [1000,1007]; and my debugger simply increments an index with no order.

Don't print this internal info to save screen space and prevent potential confusion.

samisalreadytaken avatar Aug 09 '25 15:08 samisalreadytaken

This change is Reviewable

puremourning avatar Aug 09 '25 15:08 puremourning

Thanks! Just a nit and we can merge

puremourning avatar Aug 09 '25 16:08 puremourning

Should the lines be indented for clarity?

- Thread 0: T#0 (paused)
  f2()@script.nut:10
  f1()@script.nut:20
  main()@script.nut:30
+ Thread 1: T#1 (paused)
+ Thread 2: T#2 (paused)
- Thread 0: T#0 (paused)
    f2()@script.nut:10
    f1()@script.nut:20
    main()@script.nut:30
+ Thread 1: T#1 (paused)
+ Thread 2: T#2 (paused)

samisalreadytaken avatar Aug 09 '25 17:08 samisalreadytaken

Should the lines be indented for clarity?

- Thread 0: T#0 (paused)
  f2()@script.nut:10
  f1()@script.nut:20
  main()@script.nut:30
+ Thread 1: T#1 (paused)
+ Thread 2: T#2 (paused)
- Thread 0: T#0 (paused)
   f2()@script.nut:10
   f1()@script.nut:20
   main()@script.nut:30
+ Thread 1: T#1 (paused)
+ Thread 2: T#2 (paused)

Hmm. Yeah maybe. The old id served as a visual marker but now we have a little ambiguity. Try it. See what you think.

puremourning avatar Aug 09 '25 18:08 puremourning

I think it's better with it, also more consistent with the "tree" style expand.

- Thread 0: MainThread (paused)
    main()@script.nut:36
- Thread 1: Thread 0x000002866CFFBEA0 (paused)
    ft2()@script.nut:15
    ft1()@script.nut:20
    ft()@script.nut:26
- Thread 2: Thread 0x000002866D00FEA0 (paused)
    ft2()@script.nut:15
    ft1()@script.nut:20
    ft()@script.nut:26
- Thread 0: MainThread (paused)
  main()@script.nut:36
- Thread 1: Thread 0x000002866CFFBEA0 (paused)
  ft2()@script.nut:15
  ft1()@script.nut:20
  ft()@script.nut:26
- Thread 2: Thread 0x000002866D00FEA0 (paused)
  ft2()@script.nut:15
  ft1()@script.nut:20
  ft()@script.nut:26

samisalreadytaken avatar Aug 09 '25 20:08 samisalreadytaken

Agreed

puremourning avatar Aug 09 '25 20:08 puremourning