vimspector icon indicating copy to clipboard operation
vimspector copied to clipboard

fixing unescaped double quotes

Open dsych opened this issue 4 years ago • 6 comments

Problem arises from unescaped " during evaluation e.g. "some text" in c++. I kind of knew about this, but forgot to fix. Sorry... Anyway, here is the fix and the test, too. Fixes #460

dsych avatar Sep 30 '21 04:09 dsych

This change is Reviewable

puremourning avatar Sep 30 '21 04:09 puremourning

For some unknown (to me) reason, execution pauses on enter instead of at the breakpoint. Only happens when char arr[] = "abc"; is added to the main.... To make things even stranger, this is exclusive to g++. I tried clang++ with exactly the same command clang++ -g -std=c++17 -Wall -Wpedantic simple.cpp -lpthread -o simple and it works as expected!!! So I blame this on g++.

Reviewable status: 0 of 3 files reviewed, all discussions resolved

doubly weird if it fails in macOS too as that uses clang

puremourning avatar Sep 30 '21 15:09 puremourning

doubly weird if it fails in macOS too as that uses clang

But that's apple clang, is it not? They need not be 1:1

mark2185 avatar Sep 30 '21 16:09 mark2185

there's very little materially differnent

puremourning avatar Sep 30 '21 16:09 puremourning

my guess with the tests is that inserting the lines threw off the offsets in the tests and now it's trying to add breakpoints to lines which aren't valid and so the debugger is moving them.

puremourning avatar Oct 14 '21 16:10 puremourning

It does not appear to be the case, since I tried a standalone vimspector session and am able to reproduce the problem. Anyway, I switched to a different source file to avoid investigating the problem further :D

dsych avatar Oct 16 '21 01:10 dsych

I guess this is abandoned for now. We can revisit later if we have the energy.

puremourning avatar Jan 04 '23 09:01 puremourning