pros icon indicating copy to clipboard operation
pros copied to clipboard

:sparkles: Add set/get integration time methods to optical sensor

Open SprintKeyz opened this issue 1 year ago • 4 comments

Summary:

Add the ability to get and set the integration time of the optical sensor in PROS 4

Motivation:

Before this change, PROS 4 did not have a way to get or set the integration time of the optical sensor.

Test Plan:

  • [x] Get optical sensor integration time and confirm it matches default
  • [ ] Set optical integration time to a new value
  • [ ] Get optical sensor integration time and confirm it matches new value

SprintKeyz avatar Sep 22 '24 14:09 SprintKeyz

The reason the other two boxes are not checked here is because in my testing, the VEX SDK will always return the same value of 103 when calling vexDeviceOpticalIntegrationTimeGet regardless of what the user sets it to. I am therefore unable to confirm whether this value is correctly updated, but the code in this PR should not be causing this issue (nor is this an issue the PROS team would be able to fix).

The solution is likely to do some more testing to confirm this can be reproduced and then make a vex forum post and hope this gets solved.

SprintKeyz avatar Sep 22 '24 14:09 SprintKeyz

/azp run

BennyBot avatar Oct 17 '24 20:10 BennyBot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 17 '24 20:10 azure-pipelines[bot]

Can confirm, but my results were a bit stranger. Originally I was able to set it but now I can't

SizzinSeal avatar Oct 19 '24 03:10 SizzinSeal