pros icon indicating copy to clipboard operation
pros copied to clipboard

feat: :technologist: Check device literal port numbers at compile time

Open ion098 opened this issue 1 year ago • 13 comments

Summary:

Checks port numbers for device literals at compile time rather than at runtime. (Thanks to @djava for giving me suggestions on refactoring my mess of templates into actually readable code)

Motivation:

If something can be checked at compile time, it should be checked at compile time.

Test Plan:

  • [x] check it compiles
  • [ ] check that port literals work as expected
  • [ ] check that out of range port numbers give a compile time error that is readable

Note:

This is an ABI breaking change and therefore should be a minor version bump.

ion098 avatar Jul 16 '24 18:07 ion098

/azp run

BennyBot avatar Jul 16 '24 19:07 BennyBot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 16 '24 19:07 azure-pipelines[bot]

Please fix this MR to only include relevant commits so its reviewable.

djava avatar Jul 16 '24 21:07 djava

/azp run

BennyBot avatar Jul 22 '24 18:07 BennyBot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 22 '24 18:07 azure-pipelines[bot]

/azp run

Rocky14683 avatar Nov 19 '24 18:11 Rocky14683

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 19 '24 18:11 azure-pipelines[bot]

@Rocky14683 can you rerun the pipeline please?

ion098 avatar Nov 20 '24 17:11 ion098

/azp run

Rocky14683 avatar Nov 20 '24 18:11 Rocky14683

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 20 '24 18:11 azure-pipelines[bot]

@Rocky14683 It should compile now, can you rerun the pipeline please?

ion098 avatar Nov 20 '24 18:11 ion098

/azp run

Rocky14683 avatar Nov 20 '24 18:11 Rocky14683

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 20 '24 18:11 azure-pipelines[bot]