pros
pros copied to clipboard
feat: :technologist: Check device literal port numbers at compile time
Summary:
Checks port numbers for device literals at compile time rather than at runtime. (Thanks to @djava for giving me suggestions on refactoring my mess of templates into actually readable code)
Motivation:
If something can be checked at compile time, it should be checked at compile time.
Test Plan:
- [x] check it compiles
- [ ] check that port literals work as expected
- [ ] check that out of range port numbers give a compile time error that is readable
Note:
This is an ABI breaking change and therefore should be a minor version bump.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Please fix this MR to only include relevant commits so its reviewable.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@Rocky14683 can you rerun the pipeline please?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@Rocky14683 It should compile now, can you rerun the pipeline please?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).