pros-cli icon indicating copy to clipboard operation
pros-cli copied to clipboard

UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 186: ordinal not in range(128)

Open sentry-io[bot] opened this issue 5 years ago • 2 comments

Sentry Issue: PROS-CLI-3-7P

UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 186: ordinal not in range(128)
  File "D:\a\1\s\pros\serial\interactive\UploadProjectModal.py", line 119, in project_changed
  File "D:\a\1\s\pros\serial\interactive\UploadProjectModal.py", line 90, in update_comports
  File "D:\a\1\s\pros\serial\interactive\UploadProjectModal.py", line 51, in update_slots
  File "D:\a\1\s\pros\serial\devices\vex\v5_device.py", line 595, in used_slots
  File "D:\a\1\s\pros\serial\devices\vex\v5_device.py", line 605, in read_ini

'ascii' codec can't decode byte 0xef in position 186: ordinal not in range(128)

sentry-io[bot] avatar Mar 09 '19 05:03 sentry-io[bot]

https://github.com/purduesigbots/pros-cli/blob/779d0b5bbf393b2090a64db6cb5b1a94da6a972b/pros/serial/devices/vex/v5_device.py#L605

not sure why we've explicitly decided on ascii here

HotelCalifornia avatar Mar 13 '19 15:03 HotelCalifornia

on a related note, this should also probably specify encoding='utf8' (and possibly in other places too):

https://github.com/purduesigbots/pros-cli/blob/779d0b5bbf393b2090a64db6cb5b1a94da6a972b/pros/common/ui/init.py#L169

HotelCalifornia avatar Mar 13 '19 15:03 HotelCalifornia

old will look into if it pops up again

omegaStag avatar Sep 06 '22 21:09 omegaStag