puppetlabs_spec_helper icon indicating copy to clipboard operation
puppetlabs_spec_helper copied to clipboard

Drop outdated future parser support

Open binford2k opened this issue 3 years ago • 2 comments

This is outdated and no longer supported by puppet-syntax

binford2k avatar Feb 15 '22 18:02 binford2k

Codecov Report

Merging #348 (5106954) into main (cbad6f4) will decrease coverage by 0.48%. The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   43.28%   42.80%   -0.49%     
==========================================
  Files          11       10       -1     
  Lines         841      771      -70     
==========================================
- Hits          364      330      -34     
+ Misses        477      441      -36     
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/module_spec_helper.rb 0.00% <0.00%> (ø)
lib/puppetlabs_spec_helper/puppet_spec_helper.rb 65.51% <ø> (ø)
lib/puppetlabs_spec_helper/tasks/fixtures.rb 38.36% <ø> (ø)
lib/puppetlabs_spec_helper/rake_tasks.rb 42.50% <65.00%> (+1.03%) :arrow_up:
...bs_spec_helper/puppetlabs_spec/puppet_internals.rb 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7aae63b...5106954. Read the comment docs.

codecov-commenter avatar Feb 15 '22 18:02 codecov-commenter

It would be a breaking change, except that we already accidentally broke when puppet-syntax released 3.0

binford2k avatar Feb 16 '22 00:02 binford2k

Thanks @binford2k

chelnak avatar Oct 24 '22 10:10 chelnak