puppetlabs-stdlib icon indicating copy to clipboard operation
puppetlabs-stdlib copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

Correct bcrypt salt regex

Open sabo opened this issue 3 years ago • 3 comments

This corrects the regex used by the pw_hash function for bcrypt-type hashes. The first two characters are interpreted as a strength parameter by bcrypt, and must take a value between 4 and 31 inclusive.

sabo avatar Oct 14 '22 19:10 sabo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 14 '22 19:10 CLAassistant

pw_hash is a function

Breaking changes to this file MAY impact these 11 modules (near match):

This module is declared in 318 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

puppet-community-rangefinder[bot] avatar Oct 14 '22 19:10 puppet-community-rangefinder[bot]

Hi @sabo - thanks for submitting this PR. Whilst the changes look good, could I ask that you look to resolve the present test failures and sign our CLA so we can proceed with this. :-) Thanks!

jordanbreen28 avatar Oct 17 '22 10:10 jordanbreen28

@sabo - please disregard my previous comment regarding the test failures, the failures present at first appeared to be transient. (With exception of Windows 2012 R2, these tests are regularly failing in our nightlies and not thought to be due to your PR)

Could you please rebase with the current main branch, and sign our CLA, so that we can proceed with this. Thanks!

jordanbreen28 avatar Oct 17 '22 15:10 jordanbreen28

Hi @jordanbreen28, working on getting approval for that CLA.

sabo avatar Oct 17 '22 20:10 sabo

Great @sabo - in the meantime could you rebase this PR with the current main :-)

jordanbreen28 avatar Oct 18 '22 08:10 jordanbreen28

@jordanbreen28, branch rebased and CLA signed, should be good to go

sabo avatar Oct 18 '22 18:10 sabo

@sabo Great work :-) Just one more small thing before merging, could you please squash your commits into a single commit for this PR.

jordanbreen28 avatar Oct 19 '22 11:10 jordanbreen28

You can squash on merge using GitHub's web interface.

kenyon avatar Oct 19 '22 15:10 kenyon