puppetlabs-rsync icon indicating copy to clipboard operation
puppetlabs-rsync copied to clipboard

Actually add the CI workflow

Open binford2k opened this issue 1 year ago • 7 comments
trafficstars

  • Add CloudCI publish and PR testing workflows
  • whoops, forgot to add the CI workflow

binford2k avatar Jan 10 '24 00:01 binford2k

Thanks ! I've submitted a PR to address the errors ( https://github.com/puppetlabs/puppetlabs-rsync/pull/154 ). Do you mind pulling the change (or merge the PR) ?

kajinamit avatar Jan 10 '24 06:01 kajinamit

well the errors have all been fixed. I don't have time or domain expertise to fix all the warnings.

binford2k avatar Jan 10 '24 21:01 binford2k

It seems most of the warnings are about missing descriptions. I'll try to take time to address these.

I'm wondering if we can tweak the job setting to skip warnings now . (so that we can merge this PR before all warnings are fixed)

kajinamit avatar Jan 11 '24 06:01 kajinamit

I took a quick look at one file (https://github.com/puppetlabs/puppetlabs-rsync/pull/156) but I don't have the time to finish it now.

It would make sense to me to disable parameter_types and parameter_documentation for now.

ekohl avatar Jan 11 '24 12:01 ekohl

I've created PR to add data types and parameter descriptions. https://github.com/puppetlabs/puppetlabs-rsync/pull/157

kajinamit avatar Feb 16 '24 05:02 kajinamit

@binford2k Could you please check [1] and rebase this on that one when you get time ? I'm hoping to get this merged (and also create a new release)

[1] https://github.com/puppetlabs/puppetlabs-rsync/pull/157

kajinamit avatar Mar 07 '24 10:03 kajinamit

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 23 '24 12:08 CLAassistant