storeconfigs should be in the "server" section of puppet.conf

[XMol]

Describe the Bug

The puppetdb::master::storeconfigs class will ensure the storeconfigs setting in puppet.conf is added to either the "main" or "master" section. But, according to the documentation, the latter isn't a recognized section for Puppet. Instead it should be "server".

Expected Behavior

The storeconfigs setting should be managed in either the "main" or "server" ini section of puppet.conf.

Environment

• open source Puppet-7 and Puppet-8
• presumably any, but verified for RHEL-8

Additional Context

Found this issue because our master complains in the puppetserver logfile:

Puppet You cannot collect exported resources without storeconfigs being set; the collection will be ignored

Checking puppet.conf I found storeconfigs explicitly disabled in the "server" section, while the "master" section was added through puppet-agent by this here module:

[server]
    autosign = /etc/puppetlabs/puppet/autosign.conf { mode = 0664 }
    ca = false
    external_nodes = /etc/puppetlabs/puppet/node.rb
    logdir = /var/log/puppetlabs/puppetserver
    node_terminus = exec
    parser = current
    rundir = /var/run/puppetlabs/puppetserver
    ssldir = /etc/puppetlabs/puppet/ssl
    storeconfigs = false
    strict_variables = false
    vardir = /opt/puppetlabs/server/data/puppetserver
    default_manifest = $confdir/site.pp

[master]
storeconfigs = true
storeconfigs_backend = puppetdb

[sa-dbilling]

I just noticed the same issue. After moving "storeconfigs" and "storeconfigs_backend" to the [server] section, duplicates get added back to [master].

[sandwitch]

We have the same issue and puppetserver gets a restart from another module namely 'theforeman-puppet', '21.0.0'.