puppetlabs-puppetdb icon indicating copy to clipboard operation
puppetlabs-puppetdb copied to clipboard

Use datatype Sensitive to prevent credentials leaks.

Open camilo-schoeningh-sociomantic opened this issue 7 years ago • 6 comments

I believe this might be better served by using the Sensitive data type. Let me know if that doesn't cover your use case, I may be missing something.

austb avatar Aug 09 '18 15:08 austb

@austb Cool! I missed that type. :+1:

The pr is updated.

Looks like tests are failing on this. Think you could address that @camilo-schoeningh-sociomantic?

       error during compilation: Evaluation Error: Error while evaluating a Resource
Statement, Evaluation Error: Left match operand must result in a String value. 
Got a Sensitive. (file: /home/travis/build/puppetlabs/puppetlabs-puppetdb/spec/fixtures/modules/postgresql/manifests/server/role.pp,
line: 127, column: 10) (file: /home/travis/build/puppetlabs/puppetlabs-
puppetdb/spec/fixtures/modules/postgresql/manifests/server/db.pp, line: 41) 
on node travis-job-cf78c5e3-7fbd-42e7-ab4f-fcf405004c05.c.travis-ci-prod-2.internal

binford2k avatar May 16 '19 21:05 binford2k

It's just Sensitive, not Sensitive[String]

vchepkov avatar Aug 23 '19 16:08 vchepkov

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 01 '21 18:09 CLAassistant

superseded by #331

h0tw1r3 avatar Feb 09 '24 05:02 h0tw1r3