puppetlabs-puppet_agent icon indicating copy to clipboard operation
puppetlabs-puppet_agent copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

Support for debian absolute_path to be dynamic

Open pfo-netic opened this issue 2 years ago • 6 comments

For some reason absolute_path for Debian systems is statically set to 'present' in install.pp. This seems to be because dpkg can't accept $package_version if it is set to a version or 'auto'.

This makes you unable to use a puppet installer locally placed on the system to upgrade your puppet agent on Debian.

Why not set $_package_version = $package_version and then just make sure that it is either 'present' or 'latest' and otherwise fail?

pfo-netic avatar Aug 17 '23 11:08 pfo-netic

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 17 '23 11:08 CLAassistant

Closed and reopened to kick GH checks

joshcooper avatar Sep 24 '24 15:09 joshcooper

Thoughts @kenyon @bastelfreak ?

joshcooper avatar Sep 25 '24 02:09 joshcooper

For some reason absolute_path for Debian systems is statically set to 'present' in install.pp.

I think this should read "For some reason package_version for Debian systems is statically set to present in install.pp when using absolute_source.

kenyon avatar Sep 25 '24 04:09 kenyon

@pfo-netic could you take a look at @bastelfreak and @kenyon's comments?

joshcooper avatar Mar 12 '25 02:03 joshcooper

Hi, It's such a long time since I was working with this, but it seems like you are getting the gist of what I was trying to say. If i remember correctly I just wanted this part: https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/main/manifests/install.pp#L68-L73 To work like this part: https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/main/manifests/install.pp#L86-L91

Which from my point of view it also should, which made me think it was an oversight in the first place.

pfo-netic avatar Mar 17 '25 17:03 pfo-netic