update support for Ubuntu 24.04
Summary
Ubuntu 24.04 uses the ntpsec package to manage the ntp service.
Additional Context
Add any additional context about the problem here.
- [ ] Root cause and the steps to reproduce. (If applicable)
- [ ] Thought process behind the implementation.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
- [x] 🟢 Spec tests.
- [ ] 🟢 Acceptance tests.
- [x] Manually verified. (For example
puppet apply)
I don't think the failing tests are something I can fix? I don't see any action points, at least. please let me know if there is something I can do.
On my ubuntu 24.04 server I also needed to update the driftfile location due to new AppArmor rules: ntp::driftfile: '/var/lib/ntpsec/ntp.drift'
Hi @kjetilho,
It looks like some tests are failing because of their specs also need to be updated. Also, it seems ntpsec is not accepting the jaildir parameter (-i /var/lib/ntpsec) for ubuntu-24.04. I think it is not accepting it for any platforms before it but ntpsec, which is what ubuntu24 has shifted to, is more strict about it and fails the ntp service.
I suggest not passing the jaildir opts to ubuntu 24. Here are my proposed changes: https://github.com/puppetlabs/puppetlabs-ntp/commit/d2dd320fd0cfab3f970f3aa180f3d4464840bd6a.
Please let me know your thoughts.
Thanks!
Hey @kjetilho, could you please take a look at the failures in Ubuntu 2404. I have some proposed changes, if you could review and share your thoughts it would be great: https://github.com/puppetlabs/puppetlabs-ntp/commit/d2dd320fd0cfab3f970f3aa180f3d4464840bd6a
Superseded by https://github.com/puppetlabs/puppetlabs-ntp/pull/731