puppetlabs-mysql icon indicating copy to clipboard operation
puppetlabs-mysql copied to clipboard

allow tls_options to be of String

Open janit42 opened this issue 2 years ago • 5 comments
trafficstars

the type of $tls_options has recently been changed to Array in 5131e0f806 while the code in lib/puppet/type/mysql_user.rb is able to work with it as an Array or a String.

This change allows $tls_options to by a String in addition to Array, which re-establishes compatibility with other modules, like puppet-icinga

Fixes https://github.com/puppetlabs/puppetlabs-mysql/issues/1539

janit42 avatar Mar 03 '23 10:03 janit42

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 03 '23 10:03 CLAassistant

mysql::db is a type

Breaking changes to this file WILL impact these 68 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 140 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@janit42 please rebase against main to get rid of the merge commit.

bastelfreak avatar Feb 23 '24 17:02 bastelfreak

@janit42 please rebase against main to get rid of the merge commit.

thanks for the heads-up @bastelfreak ! Anything else I can do for now?

janit42 avatar Mar 14 '24 20:03 janit42

@janit42 can you maybe add a unit test for it?

bastelfreak avatar Mar 14 '24 21:03 bastelfreak

I don't think this is needed anymore - compatibility has been ensured in related icingia module.

janit42 avatar Sep 08 '25 10:09 janit42