puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

fix in logical_volume provider, function "exists": false matches.

Open FrankVanDamme opened this issue 3 years ago • 6 comments

eg. check for lv_mysql would return true is lv_mysqllog exists. This can be fixed by improving the regex searching for the name of the LV. jira reference: https://tickets.puppetlabs.com/browse/CPR-863

FrankVanDamme avatar Oct 25 '22 13:10 FrankVanDamme

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Frank Van Damme seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 25 '22 13:10 CLAassistant

@FrankVanDamme thanks for the PR. Can you take a look at the merge conflict and resolve it?

bastelfreak avatar Oct 26 '22 09:10 bastelfreak

Hey @FrankVanDamme can you look to resolve the merge conflict so we can move this along? Thanks

jordanbreen28 avatar Jun 05 '23 07:06 jordanbreen28

Hey @FrankVanDamme - did you get the chance to review the conflicts?

jordanbreen28 avatar Jun 20 '23 07:06 jordanbreen28

This was Fixed with the implementation of https://github.com/puppetlabs/puppetlabs-lvm/pull/244 I this this can be closed

Q-Storm avatar Aug 18 '23 13:08 Q-Storm

This was Fixed with the implementation of #244 I this this can be closed

It does. Apologies for not getting around to merging this in > 1.3.0, but the change was utterly incompatible with later revisions anyway.

FrankVanDamme avatar Nov 30 '23 14:11 FrankVanDamme