puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

Be consistent when calculating sizes

Open gekmihesg opened this issue 3 years ago • 1 comments

Ensure that passing the size as integer yields the same result as passing the size as float. Also support sizes below 1 KiB.

Before:

lvm::size_to_bytes(lvm::bytes_to_size(2047))   # 1024.0
lvm::size_to_bytes(lvm::bytes_to_size(2047.0)) # 2047.0
lvm::bytes_to_size(1023) # Evaluation Error: The value '' cannot be converted to Numeric.

After:

lvm::size_to_bytes(lvm::bytes_to_size(2047))   # 2047.0
lvm::size_to_bytes(lvm::bytes_to_size(2047.0)) # 2047.0
lvm::bytes_to_size(1023) # 1023.0b

gekmihesg avatar Apr 21 '21 12:04 gekmihesg

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 21 '21 12:04 CLAassistant