puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

MODULES-10915: use facter 3 for spec test

Open b4ldr opened this issue 4 years ago • 3 comments

This likley needs fixing in pdk or .sync but wanted to at least test the fix first

b4ldr avatar Jan 11 '21 18:01 b4ldr

Codecov Report

Merging #260 (33ba906) into master (cada6d4) will increase coverage by 0.29%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   72.96%   73.25%   +0.29%     
==========================================
  Files          17       17              
  Lines         773      774       +1     
==========================================
+ Hits          564      567       +3     
+ Misses        209      207       -2     
Impacted Files Coverage Δ
lib/facter/lvm_support.rb 77.14% <100.00%> (+0.67%) :arrow_up:
lib/facter/logical_volumes.rb 100.00% <0.00%> (+11.11%) :arrow_up:
lib/facter/physical_volumes.rb 100.00% <0.00%> (+11.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cada6d4...33ba906. Read the comment docs.

codecov-io avatar Jan 11 '21 19:01 codecov-io

lvm_support spec test work with facter 3.11 all the others fact spec test work with facter 4 (and fail with facter 3). i can't see the difference that's triggering this

b4ldr avatar Jan 11 '21 19:01 b4ldr

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 01 '21 18:09 CLAassistant