puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

lvm_support: update fact to use --no-headings

Open b4ldr opened this issue 4 years ago • 2 comments

I noticed upgrading that the lvm_vg_#{vg}_pv facts dose not use the --no-headings switch like the other facts.

This PR adds the --no-headings switch and simplifies the collection

b4ldr avatar Jan 04 '21 12:01 b4ldr

Codecov Report

Merging #259 (c248f64) into master (cada6d4) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files          17       17           
  Lines         773      773           
=======================================
  Hits          564      564           
  Misses        209      209           
Impacted Files Coverage Δ
lib/facter/lvm_support.rb 76.47% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cada6d4...c248f64. Read the comment docs.

codecov-io avatar Jan 04 '21 13:01 codecov-io

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 01 '21 18:09 CLAassistant