puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

blkid returning 2 is not an error in this case

Open cbudziszewski opened this issue 5 years ago • 1 comments

blkid returns error code 2 if a path does not exist, which causes puppet to bail and not remove the lv.

A similar issue was already fixed for resizing (https://github.com/puppetlabs/puppetlabs-lvm/pull/188/files).

It may be better to wrap the blkid call somehow, since it is used multiple times in the code and has more than one valid exit code.

cbudziszewski avatar Aug 04 '20 08:08 cbudziszewski

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 24 '21 17:02 CLAassistant