puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

Fix MODULES-9914: physical_volumes provisioning with 'followsymlinks'

Open CharlieR-o-o-t opened this issue 6 years ago • 1 comments

This commit fixes broken physical device provisioning in case of symlink usage. Jira issue: https://tickets.puppetlabs.com/browse/MODULES-9914

With 'followsymlinks' enabled we should have correct set of physical volumes (should, is) in order to compare it, and apply action.

Error example: err /Stage[main]/Lvm/Lvm::Volume_group[vg1]/Volume_group[vg1]/physical_volumes change from ['/dev/sdb'] to ['/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_3243ac35-a879-4c26-b', '/dev/disk/by-id/scsi-0QEMU_QEMU_HARDDISK_0e99e7db-b97d-4017-a'] failed: Could not remove physical volume /dev/sdb from volume group 'vg1'; this physical volume may be in use and may require a manual data migration (using pvmove) before it can be removed (Execution of '/usr/sbin/vgreduce vg1 /dev/sdb' returned 5: Physical volume "/dev/sdb" still in use)

CharlieR-o-o-t avatar Sep 16 '19 14:09 CharlieR-o-o-t

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Siarhei Rasiukevich seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 24 '21 17:02 CLAassistant