puppetlabs-lvm icon indicating copy to clipboard operation
puppetlabs-lvm copied to clipboard

Managing unmanaged file resource

Open kamlane opened this issue 6 years ago • 3 comments

The Mount resource default statement is dependent on a resource not managed by the module so it bombs out; the exec statement at the bottom of logical_volume doesn't consistently execute on puppetserver 4.10 for some reason.

kamlane avatar Feb 07 '19 04:02 kamlane

Also please accept this commit, but it might be good to add something like this:

  if $mountpath == "/$name" {
        $mountpath_final = "/${name}"
  } else {
        $mountpath_final = "${mountpath}/${name}"
  }

... replace $mountpath with $mountpath_final in the lower code.

Yamakasi avatar Mar 19 '19 17:03 Yamakasi

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 24 '21 17:02 CLAassistant

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d621bd9). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage          ?   72.96%           
=========================================
  Files             ?       17           
  Lines             ?      773           
  Branches          ?        0           
=========================================
  Hits              ?      564           
  Misses            ?      209           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d621bd9...530f792. Read the comment docs.

codecov-commenter avatar Jun 05 '21 09:06 codecov-commenter