added code to manage directory file resources required for mounts and…

[ITBlogger]

… updated lvm_spec tests to use the more modern syntax

This PR addresses https://tickets.puppetlabs.com/browse/MODULES-1938

[tphoney]

Can you please rebase, this is why travisCI maybe failing for this PR. I tested this with #168
apologies for the inconvenience.

[ITBlogger]

Sorry it took me so long to rebase, but just noticed this

[tphoney]

Hi @ITBlogger thanks for the rebase. The tests look to be passing again 👍 So i spent a little more time reviewing the PR. There are a few things that stand out, i have commented inline. It would also be nice to have a line in the readme, detailing the new functionality.

Thanks for the work you have put in.

[ITBlogger]

not sure that a squash is warranted as both commits pretty much stand on their own

[tphoney]

The addition of Variant, will make the module incompatible with people using puppet 3. We cannot merge this PR until then, apologies. We have been working to migrate modules fully to Puppet 4 using all of the new language features. NTP, apt and concat are good examples of this work. Unfortunately until this happens for lvm, i am hesitant to merge this PR with this breaking change. Apologies.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Alex Scoble seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jordanbreen28]

Closing as PR is outdated. Please re-open if necessary.