puppetlabs-kubernetes icon indicating copy to clipboard operation
puppetlabs-kubernetes copied to clipboard

Minimum puppet version for puppetlabs-kubernetes 7.1.1

Open XSpielinbox opened this issue 1 year ago • 1 comments

Describe the Change You Would Like

On the Puppet Forge, for version 7.1.1 the minimum Puppet version is stated as 7.24.0, whereas for 7.1.0 it only was 6.24.0. To bump the minimum version requirement by a major version in a patch release is pretty insane in my opinion and forbidden by semantic versioning. The changelog also does not state anything related to this change. The dropping of support for Puppet 6 is stated in the changelog for verison 8.0.0.

Could it be that this is a typo in version 7.1.1?

XSpielinbox avatar Sep 24 '23 10:09 XSpielinbox

The change has been done in https://github.com/puppetlabs/puppetlabs-kubernetes/pull/626, resp. https://github.com/puppetlabs/puppetlabs-kubernetes/pull/626/commits/75f5dc74d398f285f36df680d795622712c1762f. You're right it should have been part of major release.

has_key function was part of stdlib < 9.0.0 https://github.com/puppetlabs/puppetlabs-stdlib/pull/1319/commits/f629f7b94e464d47ae1ddf334fe7bfa3b4256569 but the in operator should be working with Puppet 6. With removal of has_key it's possible to update the requirement puppetlabs-stdlib < 10.0.0, but Puppet version requirement doesn't have to change.

deric avatar Feb 22 '24 08:02 deric