etcd data dir path configurable by hiera

[metode-cz]

Signed-off-by: Miroslav Svoboda [email protected]

[puppet-community-rangefinder[bot]]

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

• jetstack-kubernetes_addons
• jetstack-fluent_bit
• jetstack-tarmak
• jetstack-prometheus
• jetstack-calico

This module is declared in 0 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

All committers have signed the CLA.

[metode-cz]

In our use case, we need move etcd data dir to different path than default is.

[SimonHoenscheid]

Would it make sense to manage the directory with puppet, to make sure it exists?

[metode-cz]

No, puppet doesn't have to do this, because etcd binary do that. Here is output log from started etcd binary: ./etcd --name xyz --data-dir /tmp/xyz

2022-08-16 16:33:42.359745 I | etcdmain: etcd Version: 3.4.17
2022-08-16 16:33:42.359897 I | etcdmain: Go Version: go1.12.17
2022-08-16 16:33:42.359907 I | etcdmain: Go OS/Arch: linux/amd64
2022-08-16 16:33:42.376602 I | embed: name = xyz
2022-08-16 16:33:42.376662 I | embed: data dir = /tmp/xyz
2022-08-16 16:33:42.376677 I | embed: member dir = /tmp/xyz/member
...

[metode-cz]

In my opinion, the errors from code review have nothing to do with my changes. Can you please test it again?

[jordanbreen28]

@metode-cz Thanks for this - looks like we will need you to rebase with the current main before we can proceed. Additionally, a spec test would be helpful to demonstrate this change.

[metode-cz]

ok, rebased

[jordanbreen28]

Thanks @metode-cz for rebasing. We think a spec test would be helpful to demo this change, i.e. where $etcd_data_dir has a default and non-default value.

[metode-cz]

I am very sorry, but I will not be able to prepare these tests as you request.

[GSPatton]

hi @metode-cz. Unfortunately when I tried to push a commit with spec tests for your PR, I wiped out your commits. We were unable to recover them on this PR but have restored them on a different PR. I apologise for the inconvenience.

We will get these changes merged for you as soon as we can. Thank you for your contributions.