puppetlabs-kubernetes icon indicating copy to clipboard operation
puppetlabs-kubernetes copied to clipboard

Support setting node role on worker nodes

Open deric opened this issue 2 years ago • 1 comments

This PR add possibility to define

kubernetes::node_role: some_role

on worker nodes.

deric avatar Aug 05 '22 07:08 deric

kubernetes::config::worker is a class

that may have no external impact to Forge modules.

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 0 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@deric Similiarly to https://github.com/puppetlabs/puppetlabs-kubernetes/pull/566, please rebase with main so we can proceed.

jordanbreen28 avatar Sep 26 '22 09:09 jordanbreen28

@deric thanks for rebasing. Before approving, could you confirm if the node_role parameter will be automatically picked by up by the template? Thanks

jordanbreen28 avatar Sep 26 '22 14:09 jordanbreen28

Sorry, this is an old PR :frowning_face: control-plane taint seems to be supported in config other roles can be assigned using labels

kubectl label node ${hostname} node-role.kubernetes.io/${role}=

but not this way.

deric avatar Sep 27 '22 10:09 deric