puppetlabs-kubernetes icon indicating copy to clipboard operation
puppetlabs-kubernetes copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

updates to allow a $kubernetes_install_method variable to accomplish:…

Open daveoy opened this issue 2 years ago • 6 comments

… https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-kubeadm-kubelet-and-kubectl "installation without a package manager"

daveoy avatar Mar 30 '22 21:03 daveoy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 30 '22 21:03 CLAassistant

Hello @daveoy ! Apologies for the lack of response and thank you for your contribution.

We will aim to review your contribution on the next Community Day. In the meantime, it looks like you have a couple of merge conflicts that need resolving. Could you get these sorted for us?

chelnak avatar May 24 '22 11:05 chelnak

Hello @daveoy ! Apologies for the lack of response and thank you for your contribution.

We will aim to review your contribution on the next Community Day. In the meantime, it looks like you have a couple of merge conflicts that need resolving. Could you get these sorted for us?

thank you @chelnak , that's done!

daveoy avatar May 24 '22 18:05 daveoy

@chelnak @bastelfreak Can we get this over the line?

daveoy avatar Jun 18 '22 03:06 daveoy

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

github-actions[bot] avatar Aug 18 '22 02:08 github-actions[bot]

hi @chelnak @bastelfreak just noticed this is still open? can we please get this done?

daveoy avatar Aug 25 '22 11:08 daveoy

@daveoy Apologies for any delay with this. There looks to be some merge conflicts, can you look to resolve these so we can assess how to proceed with this PR. Thanks

jordanbreen28 avatar Sep 26 '22 13:09 jordanbreen28

Hello @daveoy

Thank you for this PR. While we appreciate your contribution the team have decided that we aren’t going to move forward with this PR right now. We will add this to our list as a feature request and will make every attempt to consider it in the future.

Once again, thank you!

GSPatton avatar Oct 10 '22 10:10 GSPatton

Okay, just to add I'm using this on 10+ clusters in an air-gapped environment in production right now. I have a couple of updates to add to this PR as well, I'll push them to my fork and continue to reference it in case anyone ends up here looking for a solution to this problem.

daveoy avatar Oct 10 '22 12:10 daveoy