puppetlabs-firewall icon indicating copy to clipboard operation
puppetlabs-firewall copied to clipboard

Fix table parsing with * in non-table names

Open 2fa opened this issue 10 months ago • 0 comments

Summary

If iptables-save contains * in a non-table names it will break table parsing:

  1. Current table rules after encountered * will be considered absent and will be forcefully added on every puppet run without duplicate checks (cuz puppet thinks that there are no more rules in that table)
  2. Next table will be skipped completely.

Additional Context

We need to have more iptables-save parsing tests, there are more bugs at rule level as well (i will open PR tomorrow)

Checklist

  • [x] 🟢 Spec tests.
  • [x] 🟢 Acceptance tests.
  • [x] Manually verified. (For example puppet apply)

2fa avatar Apr 04 '24 17:04 2fa