puppetlabs-firewall
puppetlabs-firewall copied to clipboard
puppetlabs
Allow -_ in ipset name
Summary
Allow setting a - and _ in ipset name
Should fix #1187
Checklist
- [x] 🟢 Spec tests.
- [x] 🟢 Acceptance tests.
- [x] Manually verified. (For example
puppet apply)
@2fa FYI the "\w" already contains underscores, so as a workaround one can change - with _ in existing ipsets.
This fix would still be great if merged, as it used to work before puppetlabs-firewall 7.0.0 release.
@2fa FYI the "\w" already contains underscores, so as a workaround one can change - with _ in existing ipsets.
This fix would still be great if merged, as it used to work before puppetlabs-firewall 7.0.0 release.
Yeah, you are correct about _. I probably was fixing - and thought about to add underscore as a future-proof, but forgot that it's already included in \w.
I know that i can simple rename all ipsets to use underscores, but it worked before so for me it was better to just fix the issue.
Right now we're using the latest 6.X version, 7.0 has too many problems: it's very slow, for example. #1214
I have a similar problem but in my case it is a colon that is missing in the regex. If I have checked the ipset source, and there is no limitations besides a length limit. Even spaces are allowed, but this will probably lead to other problems in parsing.
