puppetlabs-firewall icon indicating copy to clipboard operation
puppetlabs-firewall copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

(GH-1055) Fix for `--random-fully`

Open david22swan opened this issue 2 years ago • 1 comments

Issues have arisen with the --random-fully value on certain RedHat versions. It seem's as if the logic put in around --random and --random-fully are no longer working. This change should resolve the issue and tighten the logic around the known_boolean values.

david22swan avatar Jul 13 '22 10:07 david22swan

hmmmm, fix for the spec test breaks the acceptance tests

david22swan avatar Jul 22 '22 12:07 david22swan

The customer has responded in a new support ticket this morning, the fix works as expected! Can we expect this to get merged and released once the tests have been fixed?

pgrant87 avatar Aug 30 '22 09:08 pgrant87

@pgrant87 Hey, sorry for the wait on this. Hadn't seen the notification that you got back to me on it, must have missed it. Anyway did a bit of confirmation work on the fix and discovered that it had caused/unearthed a separate issue, which I know have a fix up for as well, but wanted to make sure that the new fix didn't infringe on the old one, if you could get the customer to give it one last check before I have it merged. Again sorry for the wait

david22swan avatar Sep 28 '22 10:09 david22swan

The customer came back "I’ve re-deployed the code to ensure the new commit is included, run Puppet and haven’t seen any further issues!" looks good to go David!

pgrant87 avatar Sep 28 '22 15:09 pgrant87