puppetlabs-docker icon indicating copy to clipboard operation
puppetlabs-docker copied to clipboard

Fix docker_compose up_args

Open mcarrolle opened this issue 1 year ago • 2 comments

Summary

Fix wrong position of up_args arguments passed to command and handle up_args argument that contains value like --pull always. Issue: #984 and #996

Additional Context

Related Issues (if any)

  • #984
  • #996

Checklist

  • [x] 🟢 Spec tests.
  • [x] 🟢 Acceptance tests.
  • [x] Manually verified. (For example puppet apply)

mcarrolle avatar Sep 12 '24 12:09 mcarrolle

Any updates on this, it is blocking our upgrade of the module ?

KoenDierckx avatar Sep 25 '24 08:09 KoenDierckx

(I am not code owner)

I wonder if the argument validation for up_args is correct in the ruby-code for the docker_compose type? Input should be an array but error says it should be a String.

I also notices that this pullrequests has failing CI-tests.

rogermartensson avatar Dec 05 '24 13:12 rogermartensson