puppetlabs-docker
puppetlabs-docker copied to clipboard
Unpossible to disable icc with 10.x version of this module
Describe the Bug
When the parameter docker::icc is set to false, this parameter is completely ignored
Expected Behavior
The OPTIONS variable in /etc/sysconfig/docker should include --icc=false
Steps to Reproduce
Steps to reproduce the behavior:
- docker::icc: false in hiera
- Upgrade to 10.x version of this module
- See the --icc=false parameter disapear in /etc/sysconfig/docker
Environment
- Version 10.0.0
- Platform Almalinux 9
Additional Context
The conversion from erb to epp replaced:
<% unless @icc == nil %> --icc=<%= @icc %><% end -%>
with:
<% if $icc { %> --icc=<%= $icc %><% } -%>
Which behaves completely different when icc is false. A workaround would be to set docker::icc to the string "false", but that will not work because manifests/init.pp demands it to be a boolean.