puppetlabs-docker icon indicating copy to clipboard operation
puppetlabs-docker copied to clipboard

(maint) Add to supported platform list

Open barriserloth opened this issue 2 years ago • 2 comments

This commit adds to the list of officially supported platform. My rationale for adding Centos/RHEL 8 is because of this change: https://github.com/puppetlabs/puppetlabs-docker/pull/926 My rationale for adding SLES is because of this change: https://github.com/puppetlabs/puppetlabs-docker/pull/591

And I've also added Alma, Oracle, Rocky and Scientific to the list as well since they are all RedHat derivatives and would ideally be supported alongside RHEL.

Summary

Provide a detailed description of all the changes present in this pull request. See commit message above

Please let me know if there are any issues with this, and I'm happy to amend my changes. Thanks!

Additional Context

Add any additional context about the problem here.

  • [ ] Root cause and the steps to reproduce. (If applicable)
  • [ ] Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • [ ] 🟢 Spec tests.
  • [ ] 🟢 Acceptance tests.
  • [ ] Manually verified. (For example puppet apply)

barriserloth avatar Sep 26 '23 18:09 barriserloth

Is it possible that RHEL8 was excluded from earlier addition as Docker is not the supported container runtime for RHEL 8 & 9, plus documentation for Docker engine https://docs.docker.com/engine/install/ lists no support for RHEL apart from RHEL (s390x) which is not a supported puppet agent platform

golflimaechoecho avatar Jan 19 '24 07:01 golflimaechoecho

This section of the readme should just point the reader to metadata.json, since that's what actually matters.

kenyon avatar Jan 19 '24 15:01 kenyon