puppetlabs-docker icon indicating copy to clipboard operation
puppetlabs-docker copied to clipboard

Documentation around supported operating systems

Open barriserloth opened this issue 1 year ago • 4 comments

I'm not sure if this is exactly a documentation change, but it's also not really a code change request, so apologies in advance if this is filed in the wrong category.

It appears that the module lists support for Ubuntu, CentOS, Windows and Debian (and to some degree Redhat 7) but in testing it seems like it works for Redhat variants and SLES as well. Is there a reason that those are not listed as being officially supported? Thank you!

barriserloth avatar Sep 20 '23 22:09 barriserloth

Hi @barriserloth,

Listing a RedHat derivative and not RedHat is weird. I guess this is more of something forgotten than an intention. The metadata.json file list supported operating systems, and the test suite run on a subset of these listed operating system. Filling-in a PR to add these systems should be straightforward I think.

smortex avatar Sep 20 '23 22:09 smortex

That sounds great, thanks! I can work on getting a PR up for those changes if that's alright with you

barriserloth avatar Sep 20 '23 23:09 barriserloth

All kinds of improvement are always welcome :+1:

smortex avatar Sep 23 '23 21:09 smortex

Awesome, I've opened https://github.com/puppetlabs/puppetlabs-docker/pull/953. Thanks for your help

barriserloth avatar Sep 26 '23 18:09 barriserloth