puppetlabs-docker icon indicating copy to clipboard operation
puppetlabs-docker copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

no working parameter combination for docker 1.x and root_dir

Open Enrice opened this issue 1 year ago • 0 comments

If using the legacy distribution provided docker yum packages (1.13.1) there is no working combination of the following parameters due to wrong regexes in https://github.com/puppetlabs/puppetlabs-docker/blob/c861112cd817a930199cc072ffd3e3e593534712/manifests/init.pp#L546 and https://github.com/puppetlabs/puppetlabs-docker/blob/c861112cd817a930199cc072ffd3e3e593534712/manifests/init.pp#L609

  • version (specify or leave empty)
  • root_dir (I need that)
  • use_upstream_package_source => false (as documented in the README)
  • service_overrides_template => false (as documented in the README)
  • docker_ce_package_name => 'docker' (as documented in the README)

Actual Problem

If version is specified, all docker_ce_* parameters are ignored. If version is not specified, the root_dir_flag will be '--data-root', which does not yet exist in 1.13.1.

Environment

  • any module version, but used latest 9.1.0
  • CentOS 7

Some thoughts

The regexes trying to cover 1.x are wrong anyway: 1.\d+ matches ANY character after 1, which is not intended... And what about versions 0.x?

I would come up with the following for 0.x and 1.x: [01][.]\d+[.]\d which also addresses semver conformity.

Enrice avatar Jul 31 '23 11:07 Enrice