puppetlabs-docker icon indicating copy to clipboard operation
puppetlabs-docker copied to clipboard

Defaults memory_limit to undef instead of ignored 0b value

Open AndrewLipscomb opened this issue 2 years ago • 4 comments

Summary

From https://github.com/puppetlabs/puppetlabs-docker/issues/748 - sets the default memory_limits value to undef instead of 0b. As the Docker documentation states that 0b is an impossible value to use - it appears to be ignoring the 0b value. In which case this should not be a breaking change to any setup.

Additional Context

Add any additional context about the problem here.

  • Also helps with podman usage as per the linked issue

Related Issues (if any)

https://github.com/puppetlabs/puppetlabs-docker/issues/748

Checklist

  • [ ] 🟢 Spec tests.
  • [ ] 🟢 Acceptance tests.
  • [ ] Manually verified. (For example puppet apply)

AndrewLipscomb avatar Jun 23 '23 03:06 AndrewLipscomb

As force pushes appeared to not update the old PR at https://github.com/puppetlabs/puppetlabs-docker/pull/927 correctly - I've made a new PR. I've ran the unit tests via the PDK successfully on my local machine with this version

AndrewLipscomb avatar Jun 23 '23 03:06 AndrewLipscomb

Hi @ALTinners, can you please rebase your PR with main branch? We have recently fixed the windows pipeline so yours should be green once you rebase. I will keep eye once its green will merge PR and release the changes. Thanks

Ramesh7 avatar Jul 06 '23 09:07 Ramesh7

From your working directory (in your feature branch, and assuming 'origin' is the name of the puppetlabs remote):

git fetch origin       # Download the latest code we have here
git rebase origin/main # Move your commits on top of the main branch (this re-write history)
git push -f            # Send the changes (-f is required because we re-wrote history)

The PR will be updated automagically.

smortex avatar Jul 06 '23 17:07 smortex

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: AndrewLipscomb
:x: tombrodie
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 10 '23 01:08 CLAassistant