puppetlabs-docker Use apt::source keyring to fix apt-key deprecated warnings

This PR could possibly resolve https://github.com/puppetlabs/puppetlabs-docker/issues/884

Jan 02 '23 15:01 vegaaz

All committers have signed the CLA.

Jan 02 '23 15:01 CLAassistant

docker is a class

Breaking changes to this file WILL impact these 18 modules (exact match):

Breaking changes to this file MAY impact these 24 modules (near match):

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Jan 02 '23 15:01 puppet-community-rangefinder[bot]

Thanks for your contribution and good suggestions @bastelfreak @kenyon ! Can someone take a look at the unit/acceptance tests?

In my opinion at least spec/shared_examples/repos.rb line 24-29 need some adjustment.

Jan 03 '23 06:01 vegaaz

Yes, tests should be added or updated to test this new code.

Jan 03 '23 20:01 kenyon

Added some working unit-tests with 5373deaf806f0784c8c6423dd5aa7ae25f546610 Since I am not very familiar with rspec there are probably cleaner solutions.
Please feel free to suggest! :)

Since acceptance tests already check if installation of docker is working (and using sources is a part of it) I think there are no additional acceptance tests needed.

Jan 04 '23 13:01 vegaaz

@kenyon @bastelfreak for some reason the PR Test / Windows 2022, puppet6-nightly keeps failing. Do you have any idea? :smile:

Jan 04 '23 18:01 vegaaz

Hi @bastelfreak could you please approve the workflows to trigger the checks?

Jan 09 '23 09:01 vegaaz

@bastelfreak I am still not sure why PR Test / Windows 2022, puppet7-nightly keeps failing...
Neverthless I am excited for your review. :)

Jan 10 '23 10:01 vegaaz

I am not able to create working unit tests... Since I am not very familiar, I would love if somebody could take a look! :smile:

Jan 20 '23 08:01 vegaaz

docker is a class

Breaking changes to this file WILL impact these 18 modules (exact match):

Breaking changes to this file MAY impact these 24 modules (near match):

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Jan 23 '23 07:01 puppet-community-rangefinder[bot]

I am not able to create working unit tests... Since I am not very familiar, I would love if somebody could take a look! smile

.fixtures.yml was missing the dependency. Added via 05d75b548cf8b4695591e53bbb927c0bc9ed6d4e.

@bastelfreak could you please trigger unit/acceptance tests?

Feb 03 '23 12:02 vegaaz

@bastelfreak could you approve the workflows? :smile:

Feb 06 '23 08:02 vegaaz

Failed tests are related to internal connection errors and missing mend-configuration.
@bastelfreak how do we handle the failed tests? Could you review the latest changes? :smile:

Feb 07 '23 09:02 vegaaz

@bastelfreak @kenyon can we merge this?

Feb 13 '23 06:02 vegaaz

This affects my production environment. I would love if we could merge this asap. @kenyon @bastelfreak @david22swan

Feb 17 '23 08:02 vegaaz

docker is a class

Breaking changes to this file WILL impact these 19 modules (exact match):

Breaking changes to this file MAY impact these 24 modules (near match):

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Mar 06 '23 07:03 puppet-community-rangefinder[bot]

#rebased @bastelfreak @david22swan Please run tests and feel free to review + merge.

Mar 06 '23 07:03 vegaaz

@bastelfreak can you approve the workflows?

Mar 23 '23 21:03 vegaaz

@bastelfreak can you approve the workflows?

Failed tests are not related to Puppet code. Can we merge this ?

Mar 23 '23 22:03 vegaaz

Apologies for the delay in response @vegaaz! There is a fix currently being worked that should resolve the test failures present, so once thats merged in we can rekick these tests and ensure they are green before continuing.

Thanks for all the work on this one!

Mar 24 '23 15:03 jordanbreen28

Branch rebased Could you please run tests @bastelfreak @jordanbreen28 ? :)

Apr 07 '23 07:04 vegaaz

Windows 2022 nightly tests are failing because of: „Timeout after 10 seconds connecting“

@bastelfreak @jordanbreen28 how do we handle this ? Try again ?

Apr 07 '23 12:04 vegaaz

Bump @jordanbreen28 @bastelfreak

Apr 26 '23 17:04 vegaaz

Sorry for the delay @vegaaz.. The timeout errors is a known issue to us & not related to your code changes.

There are some bits of work ongoing in this module that we'd like to get in first before moving on with this (like support for Puppet 8), but I've made a note so this PR doesn't sit idle waiting for a response on us like it has done. (Apologies again..)

Apr 27 '23 07:04 jordanbreen28

Hey @vegaaz! The work I mentioned above has been merged in now, do you want to resolve this branches conflicts and we will think about progressing this? Thanks

May 04 '23 13:05 jordanbreen28

docker is a class

Breaking changes to this file WILL impact these 19 modules (exact match):

Breaking changes to this file MAY impact these 24 modules (near match):

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

May 04 '23 14:05 puppet-community-rangefinder[bot]

Hey @vegaaz! The work I mentioned above has been merged in now, do you want to resolve this branches conflicts and we will think about progressing this? Thanks

Hi @jordanbreen28 I rebased the Branch. Lets take a look! :)

May 04 '23 14:05 vegaaz

puppetlabs-docker puppetlabs-docker copied to clipboard

Use apt::source keyring to fix apt-key deprecated warnings

docker is a class

docker::params is a class

docker::repos is a class

This module is declared in 6 of 580 indexed public Puppetfiles.

docker is a class

docker::params is a class

docker::repos is a class

This module is declared in 6 of 580 indexed public Puppetfiles.

docker is a class

docker::params is a class

docker::repos is a class

This module is declared in 6 of 580 indexed public Puppetfiles.

docker is a class

docker::params is a class

docker::repos is a class

This module is declared in 6 of 580 indexed public Puppetfiles.

puppetlabs-docker
puppetlabs-docker copied to clipboard

This module is declared in 6 of 580 indexed public `Puppetfiles`.

This module is declared in 6 of 580 indexed public `Puppetfiles`.

This module is declared in 6 of 580 indexed public `Puppetfiles`.

This module is declared in 6 of 580 indexed public `Puppetfiles`.