puppetlabs-docker icon indicating copy to clipboard operation
puppetlabs-docker copied to clipboard

Made the function more flexible and canonical

Open wilful opened this issue 2 years ago • 2 comments

I'm not a programmer, but the old description looked very complicated and unreadable. And I can't check it for Windows

wilful avatar Oct 13 '22 23:10 wilful

docker_params_changed is a function

that may have no external impact to Forge modules.

This module is declared in 6 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

omg, i don't know how fix it =(

wilful avatar Oct 19 '22 20:10 wilful

Hi @wilful. Could you update your PR description and title to be more descriptive about what this PR is trying to achieve? Thank you!

GSPatton avatar Dec 05 '22 13:12 GSPatton

also, can you rebase your branch with the main branch?

GSPatton avatar Dec 05 '22 13:12 GSPatton

sry, no time yet to figure it out, maybe later I will return to this issue ((

wilful avatar Dec 05 '22 19:12 wilful

Looks like our tests didnt properly kick in last time there was a push. Closing and re-opening PR to restart them.

LukasAud avatar Jan 27 '23 16:01 LukasAud

docker_params_changed is a function

that may have no external impact to Forge modules.

This module is declared in 6 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

closing stale PR due to inactivity. Feel free to reopen if you feel like continuing work at some later time.

GSPatton avatar Feb 17 '23 11:02 GSPatton