puppetlabs-docker
puppetlabs-docker copied to clipboard
puppetlabs
Make management of systemd override directories optional
When using puppet-systemd and the systemd::dropin_file type to manage
custom Docker-related overrides the puppet-systemd module takes care of
creating and managing the required override directories like
/etc/systemd/system/docker.service.d and
/etc/systemd/system/docker.socket.d. This leads to duplicate resource
declaration errors because the puppetlabs-docker module also wants to
manage these systemd override directories.
This change adds a boolean parameter manage_systemd_override_dirs to
control whether this module should manage the directories
/etc/systemd/system/docker.service.d and
/etc/systemd/system/docker.socket.d. If set to 'false' then these
directories will not be touched by this module and the user must take
care of managing them, e.g. by means of puppet-systemd and
systemd::dropin_file. The parameter manage_systemd_override_dirs is
set to 'true' by default, thus backwards-compatibility is preserved.
Contains updated spec tests and parameter documentation.
docker is a class
Breaking changes to this file WILL impact these 18 modules (exact match):
- puppetlabs-cd4pe
- autostructure-docker_ee
- mindhive-nvidia_docker_runtime
- maany-simple_grid
- simp-simp_docker
- ffquintella-dockerapp
- glorpen-g_docker
- gennadyvoronkov-dcos
- walkamongus-harbor
- samuelson-dockeragent
- dodevops-hanaexpress
- knoppi-jitsi
- tomkrieger-remediate_install
- maeq-storj
- fervid-docker_ee
- puppetlabs-data_entitlement
- martyewings-githubactionboard
- betadots-hdm
Breaking changes to this file MAY impact these 24 modules (near match):
- vshn-gitlab
- puppet-gitlab_ci_runner
- pltraining-classroom
- pltraining-puppetfactory
- prozeta-portauthority
- cristifalcas-flannel
- pltraining-dockeragent
- scottyc-docker_swarm
- tsuru-router
- praekeltfoundation-seed_stack
- hesco-weave
- tsuru-registry
- jefferyb-kualicoeus
- autostructure-secure_docker
- tsuru-redis_service
- justin8-ghost
- pltraining-selfpaced
- Azcender-profile
- nick-rancher
- maasch-iot_provisioning
- pltraining-classroom_legacy
- c0deaddict-gogs
- flyer-docker_cluster
- jantman-archlinux_workstation
docker::params is a class
that may have no external impact to Forge modules.
docker::service is a class
that may have no external impact to Forge modules.
This module is declared in 6 of 579 indexed public Puppetfiles.
These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.
Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.
![puppet-community-rangefinder[bot] avatar](https://avatars.githubusercontent.com/in/22507?v=4 "Published by a pub.dev verified publisher"){kind=small}
The Windows 2022, puppet6-nightly check fails because of network timeout issues, certainly unrelated to the changes proposed in this PR. See https://github.com/puppetlabs/puppetlabs-docker/runs/8186444366?check_suite_focus=true#step:13:73 for example. Not sure how or if I can trigger running the tests again.
Hey @antaflos thanks for that ping! Your codebase is out of date, would you mind rebasing? I will get this on the list to be reviewed at our next community day (runs most Mondays)
Hi @antaflos, we have noticed this PR has been inactive for a while. An old review above by @bastelfreak suggested an alternative approach to this issue and we have agreed that it was a better solution to this problem. As such, this PR should be closed and an issue requesting that feature opened in our Issue tab here at GitHub. Thanks for your understanding.
