Update load.epp to avoid loading a module already loaded

[mz4r]

I encountered a problem during an Apache update. The scriplet executed during updates set up the default configuration of module loads. If the node with puppet agent no longer has the puppet configuration active then there is a duplicate problem in the loading of modules, example of warning returned: [so:warn] [pid 15619] AH01574: module dav_module is already loaded, skipping

The commit therefore makes it possible to load the module if it is not already loaded and thus avoid warnings on duplicates.

[CLAassistant]

All committers have signed the CLA.

[mz4r]

Can you share which OS + version you ran into this? I'd guess some EL based system since RPM can't deal with removed files (unlike DPKG for Debian), but then it would be useful to know which files. I think it's better to lay out files in a way that they overwrite native file locations instead of removing some file and creating it elsewhere.

OS : Oracle Linux 8 => 5.15.0-104.119.4.2.el8uek.x86_64

Examples files put by scriplet : 01-cgi.conf 00-base.conf 00-dav.conf 00-lua.conf

Apache module configure "loadModule" in <module_name>.load ( example "ssl.load"), but apache scriplet set in "00-ssl.conf". File list set by apache scriplet depend that installed modules.

"I think it's better to lay out files in a way that they overwrite native file locations instead of removing some file and creating it elsewhere."

Of course, i totaly agree, but the modules management is different. It would be necessary to modify the entire module management in Apache puppet module .

Scriplet apache can put many "LoadModule" in one file. example /etc/httpd/conf.modules.d/00-proxy.conf : LoadModule proxy_module modules/mod_proxy.so LoadModule lbmethod_bybusyness_module modules/mod_lbmethod_bybusyness.so LoadModule lbmethod_byrequests_module modules/mod_lbmethod_byrequests.so LoadModule lbmethod_bytraffic_module modules/mod_lbmethod_bytraffic.so LoadModule lbmethod_heartbeat_module modules/mod_lbmethod_heartbeat.so LoadModule proxy_ajp_module modules/mod_proxy_ajp.so LoadModule proxy_balancer_module modules/mod_proxy_balancer.so LoadModule proxy_connect_module modules/mod_proxy_connect.so LoadModule proxy_express_module modules/mod_proxy_express.so LoadModule proxy_fcgi_module modules/mod_proxy_fcgi.so LoadModule proxy_fdpass_module modules/mod_proxy_fdpass.so LoadModule proxy_ftp_module modules/mod_proxy_ftp.so LoadModule proxy_http_module modules/mod_proxy_http.so LoadModule proxy_hcheck_module modules/mod_proxy_hcheck.so LoadModule proxy_scgi_module modules/mod_proxy_scgi.so LoadModule proxy_uwsgi_module modules/mod_proxy_uwsgi.so LoadModule proxy_wstunnel_module modules/mod_proxy_wstunnel.so

But Apache module set in different file (proxy_ajp.load,proxy_balancer.load,proxy_connect.load ...)

Other one, the file 00-proxyhtml.conf : LoadModule xml2enc_module modules/mod_xml2enc.so LoadModule proxy_html_module modules/mod_proxy_html.so

Apache module set then in xml2enc.load and proxy_html.load

[ekohl]

So that's pretty much what I suspected. I think it's something that we should tackle properly. This now leads to 2 service restarts: once when the package is updated and once when the config is rewritten. At least the second time is downtime that shouldn't be needed.

I think an acceptance test that does the follow will catch it:

• Apply some manifest
• Verify it's idempotent
• Run dnf reinstall httpd (possibly any separate module packages)
• Apply manifest again and verify there are no changes.

Another way is to use rpm -qV httpd and verify there are no missing files in /etc/httpd.

[mz4r]

Yes, so the easiest way to avoid this problem is to:

• Check if configuration files for modules are not missing with: rpm -qV httpd
• If the "purge_configs" variable is true, we create a file with empty content to avoid the duplicate problem and the implementation of default configuration not managed by the Apache module

So we avoid restarting Apache service multiple times.

If you agree, I can do the patch on my side and reopen a pull request.

Tell me if it suits you.

[ekohl]

Check if configuration files for modules are not missing with: rpm -qV httpd

As a regression test, it would be good to have this in acceptance tests. That makes adding a new OS version (like EL 10) easier.

If the "purge_configs" variable is true, we create a file with empty content to avoid the duplicate problem and the implementation of default configuration not managed by the Apache module

https://github.com/puppetlabs/puppetlabs-apache/commit/bf9f0d04bb48649c3f5b32a1a7da0ecf89960999 is a historical precedent for this. That time it affected mod_ssl on Red Hat. Anything we missed I'd consider a bug.

So we avoid restarting Apache service multiple times.

I'd like that a lot.

If you agree, I can do the patch on my side and reopen a pull request.

Tell me if it suits you.

It does suit me. Please do.