puppetlabs-apache icon indicating copy to clipboard operation
puppetlabs-apache copied to clipboard

Add vhost "enabled" option to enable or disable it

Open BDelacour opened this issue 2 years ago • 5 comments

Hello,

I need to manually handle if a vhost is enabled and I don't want Puppet to overwrite it. Coupled with apache::purge_vhost_dir: false, it works great !

Thank you !

BDelacour avatar Mar 10 '22 09:03 BDelacour

apache::vhost is a type

Breaking changes to this file WILL impact these 129 modules (exact match):
Breaking changes to this file MAY impact these 34 modules (near match):

This module is declared in 173 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 10 '22 09:03 CLAassistant

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 10 '22 02:05 github-actions[bot]

@BDelacour Hey, sorry it's taken so long to comment on this Anyway the change look's ok to me, but would prefer it to have a more descriptive name, i.e. vhost_enabled, and some documentation added to it at the top alongside what already exists for the other variables, so that it is represented in the documentation. As an additional note we would also require it to be given a type.

david22swan avatar May 10 '22 13:05 david22swan

Hey ! Sorry I left this PR stale for some time. I'll update it soon

BDelacour avatar Jul 08 '22 09:07 BDelacour

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

github-actions[bot] avatar Oct 01 '22 02:10 github-actions[bot]