puppetlabs-apache icon indicating copy to clipboard operation
puppetlabs-apache copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

$apache::serveradmin parameter is unused

Open raybellis opened this issue 2 years ago • 7 comments

raybellis avatar Jan 27 '22 12:01 raybellis

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 27 '22 12:01 CLAassistant

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

github-actions[bot] avatar May 09 '22 02:05 github-actions[bot]

@raybellis Unsure if this is needed, was under the impressions that serveradmin is supposed to be passed through to _file_header.erb and set there?

david22swan avatar May 16 '22 11:05 david22swan

@raybellis Any chance of you coming back to this?

david22swan avatar Sep 05 '22 10:09 david22swan

@david22swan I don't have the infrastructure to set up a test for this, but the patch is still relevant. (for some reason I didn't get notifications from GitHub about your messages)

raybellis avatar Oct 11 '22 11:10 raybellis

Not sure what you mean by infrastructure, by adding testing I was referring to the addition of a small test such as this: https://github.com/puppetlabs/puppetlabs-apache/blob/main/spec/acceptance/apache_parameters_spec.rb#L323 Something to show that the parameter compiles correctly and does what is intended.

david22swan avatar Oct 11 '22 11:10 david22swan

@raybellis ^^

david22swan avatar Oct 11 '22 11:10 david22swan

I opened https://github.com/puppetlabs/puppetlabs-apache/pull/2338 as a replacement.

ekohl avatar Oct 20 '22 19:10 ekohl