puppet-vscode
puppet-vscode copied to clipboard
puppet/getVersion request uses null parameters
The extension does a request to the server to get the version however it violates the LSP spec....
It currently sends:
Content-Length: 68
{"jsonrpc": "2.0","id":1,"method":"puppet/getVersion","params":null}
However the LSP spec says params should be (https://microsoft.github.io/language-server-protocol/specifications/specification-current/#requestMessage)
/**
* The method's params.
*/
params?: array | object;
It is not allowed to be null
Need to change
https://github.com/puppetlabs/puppet-vscode/blob/891f88de0e716e0925b765dd1a5563ec6de63fb0/src/messages.ts#L4-L6
To have parameters but just be an empty hash (once JSONified)
v1.2.0 of the extension