pdk icon indicating copy to clipboard operation
pdk copied to clipboard

Add PDK_BUNDLE_IGNORE_CONFIG env support

Open fe80 opened this issue 2 years ago • 3 comments

Hello,

For some context that can be useful to define specific bundle configuration for pdk.

Example: In my case I update pdk with pdk docker images and gitlab-ci, but I also add toml as optional for :test group:

Gemfile:
  optional:
    ':test':
      - gem: 'toml'

When I run pdk update, that create a dependency fail. I would like to ignore test group with BUNDLE_WITHOUT, but I can't if BUNDLE_IGNORE_CONFIG is define.

Regards,

fe80 avatar Aug 16 '22 09:08 fe80

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 19 '23 21:04 CLAassistant

Added the blocked label for the time being as this is being discussed internally as a feature request.

chelnak avatar Jun 14 '23 08:06 chelnak

Hi @fe80.

We've been reviewing our issue backlog and found this. Apologies for the long response time on this!

Are you still interested in progressing this? It seems a good idea. To progress this further, however, we'd need more documentation and testing around the change. We'd then be able to add this to our current docs, etc.

gavindidrichsen avatar Mar 08 '24 11:03 gavindidrichsen

hey @fe80 we really like this change you've proposed.

For now we are going to set the PR to draft, until you have the bandwidth to pick this back up again and add some unit tests and documentation for the code change.

jordanbreen28 avatar Apr 12 '24 10:04 jordanbreen28

@fe80 We are gonna close this PR as unmoving, if you ever find the time to come back to it we will be more than happy to review it again and help you get it across the line.

Have a nice Spring

david22swan avatar Apr 26 '24 10:04 david22swan