puppetlabs-aws icon indicating copy to clipboard operation
puppetlabs-aws copied to clipboard

Support ELBv2/ALB

Open prozach opened this issue 7 years ago • 5 comments

We are going to be looking to make use of ALBs in the near future, and there is currently not support in the module for it. There are the client methods that got put in as part of some other work, I think by @MWilkinson, but the type and provider didn't make it to the module.

@MWilkinson Is this something that you are still working on? If you have even partially working code to submit, I think we might be able to help get this moving if its stuck.

In any case, we should add support for this AWS component.

prozach avatar Mar 09 '17 22:03 prozach

+1 Also need VPC support for ELB otherwise only EC2 Classic is supported.

ayen-tibco avatar Mar 21 '17 03:03 ayen-tibco

I suspect it will be at least a couple weeks before we begin on this if nobody else comes up with some code before then.

prozach avatar Mar 21 '17 17:03 prozach

@zleswomp sorry for not responding sooner... I did get my code to a point just before the creation of the ALB - do you want a new PR creating for it, or you can look at my fork here https://github.com/ctidigital/puppetlabs-aws/tree/feature/elbv2

MWilkinson avatar Mar 21 '17 18:03 MWilkinson

@MWilkinson Thanks for coming back. I think sending a PR with what you have currently would be good. There is definitely interest over here in supporting this feature, so even if incomplete, working from a common starting point could help others pick up where you left off.

https://github.com/puppetlabs/puppetlabs-aws/compare/master...ctidigital:feature/elbv2

prozach avatar Mar 21 '17 21:03 prozach

@zleswomp PR created #439

MWilkinson avatar Mar 22 '17 12:03 MWilkinson