puppetlabs-aws icon indicating copy to clipboard operation
puppetlabs-aws copied to clipboard

Remove requirement for unique gateway in route table

Open zvymazal opened this issue 8 years ago • 5 comments

It's an incorrect assumption that there's only one network behind a gateway. It must for example be possible to route several networks through VPN gateway.

24c77282-99fc-11e6-86c2-5b534ab887fe

zvymazal avatar Oct 25 '16 18:10 zvymazal

If you remove this validation and have a route table with multiple gateways, does puppet resource ec2_vpc_routetable report the correct gateways, or does it only report a single gateway? If puppet can't understand multiple gateways somewhere else in the module then this failure could be just to safeguard against other more obscure failures or non-idempotent puppet runs.

Thanks!

hunner avatar Jan 12 '17 17:01 hunner

@zvymazal Would you mind coming back to address the question here please?

prozach avatar Feb 10 '17 00:02 prozach

Hi @zleswomp, I believe it behaves correctly with multiple gateways because that's how we used it, but unfortunately I'm not working on that project anymore and cannot confirm on 100%.

zvymazal avatar Feb 10 '17 09:02 zvymazal

This seems like a good change. I don't know how to validate it though.

prozach avatar Feb 10 '17 23:02 prozach

This may have been taken care of with my PR #505 I had to remove the explicit requirement for the gateway in order to accommodate the peering connections.

daveseff avatar May 02 '18 23:05 daveseff