puppetlabs-aws icon indicating copy to clipboard operation
puppetlabs-aws copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs-toy-chest

#214 Add the ability to configure health check params

Open misnyo opened this issue 9 years ago • 5 comments
trafficstars

This should resolve part of the #214 enhancement

misnyo avatar Jan 05 '16 14:01 misnyo

@misnyo your change looks good in principle, but it needs rebasing on top of the current master, and please change it to two-space indents to match the rest of the codebase.

DavidS avatar Jan 08 '16 10:01 DavidS

@DavidS done, please review!

misnyo avatar Jan 08 '16 12:01 misnyo

Can you also add a health check to https://github.com/puppetlabs/puppetlabs-aws/blob/master/spec/acceptance/loadbalancer_spec.rb#L43 and a check that it actually succeeded around L100 there?

DavidS avatar Jan 08 '16 14:01 DavidS

Needs a rebase again.

prozach avatar Jul 28 '16 23:07 prozach

I'll try to get a good AWS module session in next week, where I will go through and see whether I can integrate a big chunk of all currently open PRs.

DavidS avatar Jul 29 '16 10:07 DavidS