dnsReaper Fix output file Path.

Fix for issue: #125

Oct 08 '22 11:10 mohsinenar

I cant merge this in because you haven't signed the commit.

If you sign it I will merge it in and you'll get the contributor link on the repo. If not, I'll make the change on a branch here and merge it in?

Nov 07 '22 08:11 SimonGurney

I'm not sure if this is the correct approach. In general, when specifying a path as an argument to other tools, it takes the path verbatim. It should be up to the user to specify the full path and filename for the file, allowing them to add the extension themselves.

Personally, I don't think that we should be automatically adding the extension on the end in any circumstances. Things start to get messier when you deal with formats that have many different extensions (think of .yml and .yaml, .htm and .html).

I'd rather just accept the output path as-is.

Nov 07 '22 10:11 imnotbrandon

I'm not sure if this is the correct approach. In general, when specifying a path as an argument to other tools, it takes the path verbatim. It should be up to the user to specify the full path and filename for the file, allowing them to add the extension themselves.

Personally, I don't think that we should be automatically adding the extension on the end in any circumstances. Things start to get messier when you deal with formats that have many different extensions (think of .yml and .yaml, .htm and .html).

I'd rather just accept the output path as-is.

I agree with you, however, the original behaviour was more confusing as the output bath will always have the extension automatically added even if the original bath already has an extension in it. if you want I can update my PR to support keeping the bath as it is all the time.

Nov 07 '22 15:11 mohsinenar

I'm not sure if this is the correct approach. In general, when specifying a path as an argument to other tools, it takes the path verbatim. It should be up to the user to specify the full path and filename for the file, allowing them to add the extension themselves. Personally, I don't think that we should be automatically adding the extension on the end in any circumstances. Things start to get messier when you deal with formats that have many different extensions (think of .yml and .yaml, .htm and .html). I'd rather just accept the output path as-is.

I agree with you, however, the original behaviour was more confusing as the output bath will always have the extension automatically added even if the original bath already has an extension in it. if you want I can update my PR to support keeping the bath as it is all the time.

That makes sense. Can you amend the previous commit and sign it? Signing is automatic if its done in the UI, but not sure if you can amend in the UI

Nov 07 '22 15:11 SimonGurney

Kudos, SonarCloud Quality Gate passed!